Feat(eos_cli_config_gen): Add min-links in port-channel-interfaces (a…

…ristanetworks#4790) Co-authored-by: laxmikantchintakindi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Guillaume Mulocher <[email protected]>
ClausHolbechArista · Dec 12, 2024 · 0d60a0e · 0d60a0e
1 parent 03a4f11
commit 0d60a0e
Show file tree

Hide file tree

Showing 8 changed files with 41 additions and 0 deletions.
diff --git a/...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md b/...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
@@ -5256,6 +5256,7 @@ interface Port-Channel104
    switchport trunk allowed vlan 112
    switchport mode trunk
    switchport
+   port-channel min-links 3
    port-channel lacp fallback individual
    port-channel lacp fallback timeout 300
 !

diff --git a/ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg b/ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
@@ -1926,6 +1926,7 @@ interface Port-Channel104
    switchport trunk allowed vlan 112
    switchport mode trunk
    switchport
+   port-channel min-links 3
    port-channel lacp fallback individual
    port-channel lacp fallback timeout 300
 !

diff --git a/...sta/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/port-channel-interfaces.yml b/...sta/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/port-channel-interfaces.yml
@@ -591,6 +591,7 @@ port_channel_interfaces:
         allowed_vlan: 112
     lacp_fallback_timeout: 300
     lacp_fallback_mode: individual
+    min_links: 3
 
   - name: Port-Channel105
     switchport:

diff --git a/...ions/arista/avd/roles/eos_cli_config_gen/docs/tables/port-channel-interfaces.md b/...ions/arista/avd/roles/eos_cli_config_gen/docs/tables/port-channel-interfaces.md
diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/port-channel-interfaces.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/port-channel-interfaces.j2
@@ -435,6 +435,9 @@ interface {{ port_channel_interface.name }}
 {%     if port_channel_interface.mac_access_group_out is arista.avd.defined %}
    mac access-group {{ port_channel_interface.mac_access_group_out }} out
 {%     endif %}
+{%     if port_channel_interface.min_links is arista.avd.defined %}
+   port-channel min-links {{ port_channel_interface.min_links }}
+{%     endif %}
 {%     if port_channel_interface.lacp_fallback_mode is arista.avd.defined %}
    port-channel lacp fallback {{ port_channel_interface.lacp_fallback_mode }}
 {%     endif %}

diff --git a/python-avd/pyavd/_eos_cli_config_gen/schema/__init__.py b/python-avd/pyavd/_eos_cli_config_gen/schema/__init__.py
diff --git a/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml b/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
diff --git a/...-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml b/...-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
@@ -392,6 +392,15 @@ keys:
             - str
           min: 0
           max: 300
+        min_links:
+          type: int
+          convert_types:
+            - str
+          min: 0
+          max: 120
+          description: |-
+            Minimum number of ports required up before bringing up a port-channel.
+            Maximum in `min_links` is hardware dependent.
         lacp_fallback_mode:
           type: str
           valid_values: