Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rural road tiles on (M) overmap faces wrong way for Isherwoods #77100

Open
ninersheep opened this issue Oct 17, 2024 · 7 comments
Open

Rural road tiles on (M) overmap faces wrong way for Isherwoods #77100

ninersheep opened this issue Oct 17, 2024 · 7 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@ninersheep
Copy link

ninersheep commented Oct 17, 2024

Describe the bug

Rural road on (M) overmap faces wrong way whichever overmap tileset you pick, I've tried Larwick Overmap, MSXotto+, Pen & paper Overmap.

ASCII is correct, tiles are not. Look at screenshot section.

It is O.H release candidate cdda-0.H-2024-10-02-0323 (2 weeks ago)

Edit: Aparently thats right in front of Isherwood farms, according to an achievement.

Attach save file

Rosenberg-trimmed.tar.gz

Steps to reproduce

  1. Download my save and launch it
  2. Check (M)
  3. Try turning off tilesets entirely and notice ASCII renders fine,

Expected behavior

Tileset tiles facing correct way

Screenshots

obraz
obraz

In-world the road appears correctly.
obraz
obraz

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.4317 (23H2)
  • Game Version: 1240ace [64-bit]
  • Graphics Version: Tiles
  • Game Language: English <color_dark_gray>(100.0%) [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@ninersheep ninersheep added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 17, 2024
@Procyonae
Copy link
Contributor

This should be fine in exp the tileset json changes just haven't been backported

@harakka
Copy link
Member

harakka commented Oct 18, 2024

@Procyonae if you can tell me what I missed, I'd be happy to try fixing that. Unless this requires all of your changes we decided to back out? Were these already broken before that?

@Procyonae
Copy link
Contributor

Procyonae commented Oct 18, 2024

I think I brainfarted, #72431 was after the split (and doesn't want backporting) so this is probably unrelated, I think rather than fixing this issue I did that PR which broke them in a different way and then fixed that instead

@Night-Pryanik
Copy link
Contributor

Duplicate of #61764.

@Night-Pryanik Night-Pryanik closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@Procyonae
Copy link
Contributor

I don't really see how that's a dupe when this is targeting the stable candidate and that issue looks like it should've been closed afaik

@Night-Pryanik
Copy link
Contributor

How it's not a dupe? The issue was here 2 years ago, and it's still here. That issue is still valid.

@harakka
Copy link
Member

harakka commented Oct 18, 2024

Because this is fixed for a lot of cases already in exp and 0.H. The case in the screenshot in this issue, Isherwoods', is specifically only broken for 0.H and is fixed in exp.

The case showcased in the issue you linked, trailer park, is already also fixed in 0.H.

image

@Night-Pryanik Night-Pryanik reopened this Oct 18, 2024
@ninersheep ninersheep changed the title Rural road tiles on (M) overmap faces wrong way Rural road tiles on (M) overmap faces wrong way for Isherwoods Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

4 participants