Audit all dependencies #267
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hi @RCode-Blue, I can see the trello card is in for review section but PR is a draft. Is PR ready for review?
There was a problem hiding this comment.
Hi @RCode-Blue ,
Thx for your PR 🙇🏽
Apologies it's taken me so long to review it!
I've left some comments in the PR for you.
| @@ -11,6 +11,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@chakra-ui/react": "^1.6.8", | |||
| "@chakra-ui/theme-tools": "^2.0.16", | |||
There was a problem hiding this comment.
Hi @RCode-Blue ,
why do we need @chakra-ui/theme-tools package?
This dependency wasn't explicitly mentioned in the main branch.
| @@ -22,8 +23,7 @@ | |||
| "highcharts-react-official": "^3.0.0", | |||
| "next": "^11.1.0", | |||
| "react": "17.0.2", | |||
| "react-dom": "17.0.2", | |||
| "react-icons": "^4.3.1" | |||
| "react-dom": "17.0.2" | |||
There was a problem hiding this comment.
Hi @RCode-Blue ,
we use "react-dom": "^18.2.0" in main branch;
Why should we downgrade the package to version 17.0.2 ?
also, we are using React v18 in main branch. Is there a reason why we should downgrade to v17?
Overview of the Pull Request:
Ran
depcheckto discover missing and unused libraries.react-icons.link to Trello card or Github issue
https://trello.com/c/BTqLfTNb/75-dev-audit-of-all-dependencies
How Has This Been Tested?
Pull Request Checklist:
Make sure the following checkboxes
[ ]are checked withxbefore sending your PR -- thank you!mainbranch?npx prettier --check .return no warnings/errors?