fix: dispose model references

CodinGame · Jan 30, 2024 · d3188f7 · d3188f7
1 parent 89c73ff
commit d3188f7
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/MonacoEditor.tsx b/src/MonacoEditor.tsx
@@ -202,10 +202,12 @@ function MonacoEditor ({
       setModelReady(false)
 
       const value = valueRef.current
+      let modelIRefPromise: Promise<IReference<ITextFileEditorModel>> | undefined
       let modelIRef: IReference<ITextFileEditorModel> | undefined
       let model: monaco.editor.ITextModel
       if (fileUri != null) {
-        modelIRef = await createModelReference(monaco.Uri.parse(fileUri), value!)
+        modelIRefPromise = createModelReference(monaco.Uri.parse(fileUri), value!)
+        modelIRef = (await modelIRefPromise)!
         if (cancelled) {
           modelIRef.dispose()
           return () => {}
@@ -228,6 +230,7 @@ function MonacoEditor ({
         if (editorRef.current != null) {
           lastSaveViewState(editorRef.current, model)
         }
+        modelIRefPromise?.then(modelIRef => modelIRef.dispose(), console.error)
         modelRef.current = undefined
       }
     }