Repository navigation
enhancement/issue-52: API changes requested to support persistence - #53
Merged
Merged
Conversation
* Promoted `matchesIdentity(final @nullable Identifiable other)` as default implementation in `Identifiable` interface. * Deleted duplicate `matchesIdentity(final @nullable Identifiable other)` methods from `Identifiable` implementations. * Modified `Bento` to implement `Identifiable` interface, added a second constructor to accept an `identifier` as a parameter, and modified the default constructor to provide a default `identifier`. * Increased the scope of some methods from `private` to `public`. * Modified `DragDropStage` to make the `parent` attribute nullable. * Added `setUncollapsedSize(double size)` to `DockContainerLeaf`.
* Deleted duplicate `matchesIdentity(final @nullable Identifiable other)` methods from `Dockable` and `DockContainerBranch`.
* Add Javadocs. * Convert spaces to tabs.
* Cleanup.
* Add test for default `matchesIdentity` implementation that was moved to the `Identifiable` interface.
Col-E
reviewed
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52 - API changes needed to save and restore layouts from a separate persistence module:
matchesIdentity(final @Nullable Identifiable other)as default implementation inIdentifiableinterface.matchesIdentity(final @Nullable Identifiable other)methods fromIdentifiableimplementations.Bentoto implementIdentifiableinterface, added a second constructor to accept anidentifieras a parameter, and modified the default constructor to provide a defaultidentifier.privatetopublic.DragDropStageto make theparentattribute nullable.setUncollapsedSize(double size)toDockContainerLeaf.No changes to existing behavior.
Independent of PRs #46, #48, and #50.