Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Esbuild bundler. #239

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Move to Esbuild bundler. #239

merged 1 commit into from
Mar 12, 2024

Conversation

samyakkkk
Copy link
Contributor

This PR enables bundling our extension using Esbuild which combines all js files into a single big extension.ts hence reducing our compiled extension size from 14.5MB -> 934KB. 🙌🏼

To note, ESbuild now will also bundle our debug and test builds instead of tsc. So please test the PR once on your system, by

  1. Running Extension
  2. Running Tests
  3. Making sure changes made in the code reflect in the extension.

You will also be prompted to install esbuild Problem Matchers by Connor Peet, it is recommended to install it.

Vscode Documentation on bundling: https://code.visualstudio.com/api/working-with-extensions/bundling-extension#using-esbuild

Copy link
Collaborator

@wadhia-yash wadhia-yash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to restart your VS code after installing esbuild Problem Matchers. After this it works as expected

@samyakkkk
Copy link
Contributor Author

Ok @wadhia-yash, thanks for the confirmation.

I'm merging the PR.

@samyakkkk samyakkkk merged commit ac1d6cb into develop Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants