try to orient bar jobs on reference to left-align downstream #1248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minigraph-cactus VCFs are not left-aligned, which could be confusing to people who expect that.
This PR tries to address this by orienting BAR jobs in the direction of the reference genome, under the assumption that abPOA will then take care of left aligning. It does so my changing the
getDominantEnd()
function to use strand information to break ties. So if two ends both have the maximum number of adjacencies, it'll pick the end that has the most adjacencies coming out of it in the forward orientation. In pangenome mode, it will prioritize adjacencies that are forward on the reference event.The problem is that it doesn't appear to do much on the yeast pangenome test. Here's the output of
bcftools norm -f
for themaster
branch, using the reference-guided orientationref-adj
, and the orientation of all ajdacencies (all-adj
)Adding either heuristic only increases left alignment by about 2.5%, with no advantage of giving the reference special treatment over just using all the adjacencies.