[IGraphic] Issue with union

[Hideman85]

While debugging inside The-Forge for understanding why it cannot find the right device queue I found the following issue:

The-Forge/Common_3/Graphics/Interfaces/IGraphics.h

Lines 2635 to 2641 in a00d6d3

	union
	{
	uint8_t mGraphicsQueueFamilyIndex;
	uint8_t mTransferQueueFamilyIndex;
	uint8_t mComputeQueueFamilyIndex;
	};
	uint8_t mQueueFamilyIndices[3];

This code does an union on the 3 uint not with the array as I'm pretty sure is expected.

Should be as follow:

union {
    struct {
        uint8_t mGraphicsQueueFamilyIndex;
        uint8_t mTransferQueueFamilyIndex;
        uint8_t mComputeQueueFamilyIndex;
    };
    uint8_t mQueueFamilyIndices[3];
};

Therefore the 3 uint are united to the array. Hope this helps.
I'm still trying to figure out since I've update from 1.58 to new FSL2 & up to 1.63 why nothing runs anymore.

EDIT: I just checked the diff with 1.58 revision and it was actually good beforehand 🤔

The-Forge/Common_3/Graphics/Interfaces/IGraphics.h

Lines 3028 to 3037 in c166569

	union
	{
	struct
	{
	uint8_t mGraphicsQueueFamilyIndex;
	uint8_t mTransferQueueFamilyIndex;
	uint8_t mComputeQueueFamilyIndex;
	};
	uint8_t mQueueFamilyIndices[3];
	};

Additionally, could you please add me back to the new discord server 🙏 I know it is recent, private and selection.
I've been accepted and then ejected after trying to get understanding & help on my issue.
I would be really grateful if you could add me back and help each others around 🙌

[gjaegy]

I'm facing the same problem, I don't understand this union, it's likely a bug since we have this code in vulkan.c:

I'll fix the code on our end, but it would be a good idea to fix it in the main repo...

Thanks a lot for your work !