Skip to content

UX solution for users interacting with both column and timestamp filters - #687

Merged
conservationtimothy merged 2 commits into
fix/684-filter-panel-remountfrom
feat/685-filter-applied-buttons
Sep 17, 2026
Merged

conservationtimothy merged 2 commits into
fix/684-filter-panel-remountfrom
feat/685-filter-applied-buttons

Conversation

@conservationtimothy

Copy link
Copy Markdown
Contributor

Goal

Show when a column filter, a date filter, or both filters are applied. Closes #685

Screenshots

CleanShot 2026-09-17 at 10 15 50@2x CleanShot 2026-09-17 at 10 07 13@2x CleanShot 2026-09-17 at 10 07 06@2x CleanShot 2026-09-17 at 10 06 56@2x

What I changed and why

  • MapFilterControls now tracks columnFilterActive and dateFilterActive separately from popup open state
  • A column filter is considered active when the selection has one or more values; a date filter is active when TimestampFilter emits active: true, meaning the month range is not the full span
  • Each button uses aria-expanded for the open popup and aria-pressed for the applied filter state
  • Active filter buttons show a white ring and an amber badge; both can show simultaneously so an AND of column and date filters is visible even when no popup is open
  • Hidden date-slider tooltips use display: none to prevent them from drawing over the column panel

How I convinced myself this is right

Manual testing

What I'm not doing here

This PR does not change how date and column filters combine on the map as that AND already exists.

LLM use disclosure

Grok 4.6

@conservationtimothy
conservationtimothy added this pull request to stack #688 September 17, 2026 09:25

@rudokemper rudokemper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution. Thanks.

@conservationtimothy

Copy link
Copy Markdown
Contributor Author

Pleasure as always !

@conservationtimothy
conservationtimothy merged commit 062f23e into main Sep 17, 2026
4 checks passed
@conservationtimothy
conservationtimothy deleted the feat/685-filter-applied-buttons branch September 17, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX solution for users interacting with both column and timestamp filters

2 participants