UX solution for users interacting with both column and timestamp filters - #687
Merged
conservationtimothy merged 2 commits intoSep 17, 2026
Conversation
conservationtimothy
added this pull request to stack #688
September 17, 2026 09:25
Contributor
Author
|
Pleasure as always ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Show when a column filter, a date filter, or both filters are applied. Closes #685
Screenshots
What I changed and why
MapFilterControlsnow trackscolumnFilterActiveanddateFilterActiveseparately from popup open stateTimestampFilteremitsactive: true, meaning the month range is not the full spanaria-expandedfor the open popup andaria-pressedfor the applied filter statedisplay: noneto prevent them from drawing over the column panelHow I convinced myself this is right
Manual testing
What I'm not doing here
This PR does not change how date and column filters combine on the map as that AND already exists.
LLM use disclosure
Grok 4.6