Refactor alert layer visibility handling - #700
Open
Atmosfearful wants to merge 1 commit into
Open
Atmosfearful wants to merge 1 commit into
Atmosfearful wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Prerequisite cleanup before #641
Per comment here #641 (comment)
Extract alert map visibility handling while keeping the behavior consistent.
Screenshots
Not applicable; no UI changes.
What I changed and why
Moved alert-group and secondary-data layer visibility into shared helpers. Both the legend toggle and reset now use the same rules, reducing duplicated logic and keeping layer visibility in sync.
How I convinced myself this is right
All 786 unit tests passed, along with the production build and ESLint. I also added tests for alert layers, missing layers, and the secondary-data stroke. An independent review found no remaining issues.
What I'm not doing here
I’m not refactoring the broader map setup or layer creation code.
LLM use disclosure
GPT-6 Luna for discovery, plan, implement, review loop via OpenCode TUI