Repository navigation
Conversation
# Conflicts: # canvas-api/paper-patches/files/src/main/java/org/bukkit/map/MapPalette.java.patch
no conflicts
|
Is canvas 26.3 planned to release with paper 26.3 stable? Because NGL I'm impatient and IMO profilers (timings, vanilla profiler, folia profiler etc.) have kind of been irrelevant and unused since spark sampler just works better. |
Any software can't be stable when the software they highly depend on is not marked as stable. |
You can always use unstable Canvas builds; in truth the “stable” channel is misleading as the only thing differentiating it from alpha and beta is that it had more time to mature, and whenever a new build comes out, the previous one can be considered unstable no matter what channel the software is on. The Canvas team all have their own lives, their own ideas they want to implement in the project which take time, and hasting releases can make them more likely to prove to contain issues and make us ship software we and users might not be happy with. |
I'm saying when paper base becomes stable (which is looking very soon) |
Okie dokes. |
|
Canvas 26.3 has experimental jars out rn on our downloads page. Canvas 26.3 has more things left to do until Im comfortable with this version being marked as stable. |
This does fucking nothing BTW. This is literally passed into the "hasTime" boolean supplier, but like there are 0 usages of this. This is for future-proofing, since Id like this fixed incase this DOES get used in the future.
Whoopsies my computer froze during this(I think was new kernel update) and for some reason the Region Threading patch details got deleted in a previous upstream. Added back now!
Signed-off-by: Dueris <duerismc@gmail.com>
Signed-off-by: Dueris <duerismc@gmail.com>
|
ooh beta now, ima run in production wish me luck 🙏 |
This method is modeled after PlayerList#respawn, which added this call in 26.3, this now properly reflects that change Signed-off-by: Dueris <duerismc@gmail.com>
This also adds thread checks for new 26.3 post effects API Signed-off-by: Dueris <duerismc@gmail.com>
Signed-off-by: Dueris <duerismc@gmail.com>
Update to 26.3 - Wilderness Bound - https://www.minecraft.net/en-us/article/minecraft-java-edition-26-3
Details
There are still a few things needing to be finished up with this update, primarily relating to commands and also merging the extended view branch and rewriting the region profiler implementation. Once those are done we can move to
BETA, but for now I think it's fine to move toALPHAgiven everything seems to work fine for now, however Id like testing to start happening(hence why I want to start getting initialALPHAbuilds out).trackmethods executing in the value swap lock, which makes this safe.teleportAsyncto avoid calling the Paper teleport events, and to ensure that we are randomly teleporting within the region bounds. We had this change in 26.2, however this was refined in this update a bit to ensure that the entity is kept inside the region properly.RandomState#garbageCollectwas moved to the god tick from the region tick for performance reasons, since this is a method that locks thedensityBufferPoolLockduring collection.posteffectandcompute.posteffectwas changed to be properly regionized,computewas disabled. This should be investigated more in-depth later to verify whether or not we can implement thecomputecommand.PlayerList#playerPermissionswas changed to aConcurrentHashMap, despite being unused, for future-proof sake.I have reviewed the server-side Vanilla diff in full, and noted things which needed to be changed and accounted for. I may have missed something fs, so please LMK if I did.
I think we should also have a discussion about the Minecraft debug commands, since that is something that can be enabled via a flag, and I do not think we properly regionize any of those commands. It should be discussed whether or not those should be regionized properly or not.
Remaining TODO:
datacommand fixlootcommand fixskeleton-aim-accuracyconfigAnyone viewing this PR is welcome to review, if any questions arise, ping me in Discord
#canvas-dev/#canvas-contribchannel or ask in here.