Gst alsa start at #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ham22
requested changes
Nov 30, 2016
| Subject: [PATCH] Synchronize playback support using alsa start-at | ||
|
|
||
| Change-Id: I1189aaa8e2d66f664afe89a63490b792ca928143 | ||
| Signed-off-by: Abhilash Tuse <[email protected]> |
There was a problem hiding this comment.
A bit of a description of what the patch does would be useful here. Same for the alsa patch too.
Also, some developers put significant effort into this, perhaps mention some of the key players in signed off by.
Adds API for starting a playback stream at a specified absolute time. Signed-off-by: Abhilash Tuse <[email protected]>
abhilashtuse
force-pushed
the
gst-alsa-start-at
branch
from
5faa2c7 to
d88de3a
Compare
MJNowakowski
suggested changes
Dec 2, 2016
| --- a/ChangeLog | ||
| +++ b/ChangeLog | ||
| @@ -1,3 +1,14 @@ | ||
| +2016-11-22 gettextize <[email protected]> |
There was a problem hiding this comment.
gettextize update has nothing to do with with adding playback support, so why is it added in this patch file?
| Signed-off-by: Abhimanyu Vishwakarma <[email protected]> | ||
| Signed-off-by: Matin Momin <[email protected]> | ||
| Signed-off-by: Sagar Tikore <[email protected]> | ||
| Signed-off-by: Marcin Nowakowski <[email protected]> |
There was a problem hiding this comment.
AFAIR there was no work done by me here except for the gettext version update, which must not be part of this patch.
added 2 commits
December 2, 2016 15:33
This patch adds alsaclock implementation along with start-at integration into gst alsa plugin. Signed-off-by: Abhilash Tuse <[email protected]>
Signed-off-by: Abhilash Tuse <[email protected]>
abhilashtuse
force-pushed
the
gst-alsa-start-at
branch
from
d88de3a to
1ecce38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile tested: MIPS, Creator Ci40 (https://github.com/CreatorDev/openwrt)
Description:
Alsa start-at facilitates starting a playback stream at a specified absolute time, which can be used to achieve synchronized playback.
This connects to CreatorDev/openwrt#112