Repository navigation
fix: DCNumJobRunner.get_status counted plumbing progress twice - #58
Merged
paulmueller merged 2 commits intoNov 5, 2026
Merged
Conversation
After the "plumbing" step, its full weight was added to the progress, and its partial progress was added on top, so the reported progress reached roughly 130% during the "cleanup" step. Only add the partial progress while plumbing is not yet complete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 87.64% 87.61% -0.03%
==========================================
Files 63 63
Lines 4369 4369
==========================================
- Hits 3829 3828 -1
- Misses 540 541 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while documenting the API (#52).
In
get_status, the partial plumbing progress (_progress_bn) was added withifinstead ofelif, i.e. also after plumbing had completed and its full weight was already counted. During the "cleanup" step the reported progress was therefore about 130 % (with the defaultbasin_strategy="drain"). The "done" state masked this because it sets the progress to 1.Impact / PPID: only the progress reported to the user is affected; no PPID generation change needed.
History: present since plumbing progress was introduced in 58202bc ("enh: add plumbing pipeline progress monitoring"), first released in 0.20.0. It is not a regression of earlier behavior.
Test:
test_get_status_progress_cleanup(fails without the fix: progress 1.298).🤖 Generated with Claude Code