Repository navigation
fix: relative path_in with path_out in a different directory - #60
Merged
paulmueller merged 1 commit intoNov 5, 2026
Merged
Conversation
The temporary basin-based input file is created next to the output file, and `create_with_basins` resolves relative basin paths relative to that file. A relative `path_in` thus pointed to a non-existent basin and the pipeline failed with a KeyError for 'experiment:event count'. Use absolute basin paths in `Background.__init__` and `DCNumJobRunner.dtin`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 63 63
Lines 4369 4369
=======================================
Hits 3828 3828
Misses 541 541 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paulmueller-agent
pushed a commit
to paulmueller-agent/dcnum
that referenced
this pull request
Nov 5, 2026
This works since the fix for relative `path_in` with `path_out` in a different directory (DC-analysis#60). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
DCNumPipelineJobwith a relativepath_inand apath_outin a different directory (e.g.path_in="data.rtdc",path_out="sub/out.rtdc") ended in state "error" withraised at
assert len(self._data_temp_in) > 0inDCNumJobRunner.dtin.Cause: the temporary basin-based input file is created next to the output file, and
create_with_basinsresolves relative basin paths relative to the file it writes. The relativepath_inwas stored verbatim as basin path, so it pointed to a non-existent file in the output directory. The file is first created inBackground.__init__(viapaths_ref), andDCNumJobRunner.dtinhas the same pattern as a fallback.Fix: use absolute basin paths in both places. The final output file is unaffected; it already stores both relative and absolute paths to the input.
Test:
test_basin_relative_path_in_with_path_out_in_other_directoryintests/test_logic_pipeline.py(fails on main with the KeyError above, passes with this change). flake8 is clean andruff checkreports no new findings.🤖 Generated with Claude Code