Uploaded Artists: fix fetching and displaying uploaded artists

[mattcarter11]

Before, you could not fetch and display the privately owned (uploaded) artists

Uploaded artist

YouTube artist

Also fixed:

• not all chips syncing when being selected
• don't sync if no connection. Finish sync if no error while fetching ytm data
• when syncing playlist, exclude liked playlist by id, not by order
• change text sort by date to sort by liked when songs liked filter is active

[mattcarter11]

@mikooomich a fix from a missing piece from the big PR

[mikooomich]

Do you know why it crashes when trying open pages for local artists?

Process: com.dd3boh.outertune.debug, PID: 26517
java.lang.NullPointerException: Parameter specified as non-null is null: method androidx.room.RoomSQLiteQuery.bindString, parameter value
	at androidx.room.RoomSQLiteQuery.bindString(Unknown Source:3)
	at com.dd3boh.outertune.db.DatabaseDao_Impl.__fetchRelationshipartistAscomDd3bohOutertuneDbEntitiesArtistEntity_1(DatabaseDao_Impl.java:12524)
	at com.dd3boh.outertune.db.DatabaseDao_Impl.-$$Nest$m__fetchRelationshipartistAscomDd3bohOutertuneDbEntitiesArtistEntity_1(Unknown Source:0)
	at com.dd3boh.outertune.db.DatabaseDao_Impl$112.call(DatabaseDao_Impl.java:9829)
	at com.dd3boh.outertune.db.DatabaseDao_Impl$112.call(DatabaseDao_Impl.java:9802)
	at androidx.room.CoroutinesRoom$Companion$createFlow$1$1$1.invokeSuspend(CoroutinesRoom.kt:129)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
	at java.lang.Thread.run(Thread.java:1012)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: 

For example, local artists look like this where the are some null fields, and isLocal = 1

The page before this pr

[mattcarter11]

@mikooomich i'll take a look.

Also here I've added two sync fixes:

• not all chips syncing when being selected
• don't sync if no connection. Finish sync if no error while fetching ytm data

[mattcarter11]

@mikooomich I think I've found the problem and fixed it!

[mattcarter11]

@mikooomich also, after adding the corutines to sync songs faster. I found a kind of problem caused by that: the songs are added in a different order compared to what YTM returns. So, if you sort by date added, it's not identical to what YTM responds.

This I think is fine except for likes, I find it annoying that if I order songs by liked date, it's not identical to YTM. What do you think? Should we revert the corutine at the end of syncLikedSongs() and just leave a for each for adding the likes?

Another option I see is to do first the toggle like logic linearly and then insert/update with a corutine

[mikooomich]

@mattcarter11

Another option I see is to do first the toggle like logic linearly and then insert/update with a corutine

IIRC toggle like just assigns a timestamp, so that would be a best of both worlds solution. Though, I'd have some thread limit (ex. thread pools) for jobs like this, if dispatchers doesn't do this automatically.

But also...

Does coroutines can provides significant performance boost over just a simple for? The db transactions are processed sequentially anyways. I'd imagine you put the val localSong = outside of the transaction because it deadlock(?). Maybe putting everything in one transaction and doing everything in a regular for loop may yield better results, and avoid such deadlocks?

I haven't had the time to look at this too closely, but in general, do what you think would be best; you probably are more familiar with this code than me. Thanks for doing the sync work I dread lol

[mattcarter11]

@mikooomich okey. For now, I'll let the likes sync as a simple for loop. Later we can improve this. If the rest of the changes seem ok could you merge the PR? I have other changes on a branch based on this one but related to other stuff that i would like to open a PR.

Just for spoliers.....🤫🤫

[mikooomich]

Yeah, I'll merge it and later on make stuff efficient and/or fix bugs.

Remote artists have a little ui issue when offline. Maybe squeeze this fix in somewhere, or I'll get around to it... eventually

[mikooomich]

@mattcarter11 do you know why this is done? Doesn't this always set showLocal to true? Currently, when online, only local content will be shown, and to my knowledge, the online content is never shown.

From what I gather, you want to show offline content when offline and online content when online?

[mikooomich]

Also, I would like to merge in the compose 1.7 changes soon (since they'll probably end up conflicting badly), are you ok with me merging that in after your 3 prs (#127 #125 #121)?

Here is the branch with compose changes rebased on current dev https://github.com/mikooomich/OuterTune/tree/canary

[mattcarter11]

@mikooomich ow, it's missing some logic, here's a fix: #128
About the merge, yes, currently I don't have new code to PR (but I will) so all good for me