Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player rework #202

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Player rework #202

merged 7 commits into from
Jan 11, 2025

Conversation

gechoto
Copy link
Contributor

@gechoto gechoto commented Jan 11, 2025

What is it?

  • New feature (user facing)
  • Update to existing feature (user facing)
  • Bugfix (user facing)
  • Translations
  • Codebase improvements or refactors (dev facing)
  • Other

Description of the changes in your PR

  • add NewPipeExtractor for stream url deobfuscation
  • rework player requests and add client fallback system
  • decouple player and registerPlayback functions
  • port of Player fixes z-huang/InnerTune#1789

Fixes the following issue(s)

Due diligence

  • I read the contribution guidelines.
  • I understand that in the event of merge conflicts, I may be asked to rebase my branch on top of the dev branch, instead of resolving them by merging dev into my own branch

@gechoto gechoto mentioned this pull request Jan 11, 2025
8 tasks
@gechoto
Copy link
Contributor Author

gechoto commented Jan 11, 2025

@mikooomich please merge before other PRs. I can't believe I just spent two hours on this. Not gonna rebase again.

@mikooomich
Copy link
Collaborator

Yeah... Hence why I was hesitant to redo the old pr properly. Will merge once I give it a look over. Thanks!

@mikooomich mikooomich merged commit b2e6983 into DD3Boh:dev Jan 11, 2025
1 check passed
@mikooomich
Copy link
Collaborator

mikooomich commented Jan 11, 2025

Succeeds #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants