Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect DBs #158

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Reconnect DBs #158

merged 1 commit into from
Nov 2, 2023

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Oct 24, 2023 •
edited
Loading

Uses #169

  • add a pool lifetime for sqlalchemy
  • try reconnecting SQL and OS DBs in the dependency mechanism
  • keep the symmetry between sql and os db for transaction, even if transactions aren't effective in OS

@chrisburr chrisburr linked an issue Oct 26, 2023 that may be closed by this pull request
Application startup behaviour #90
Closed
@chaen chaen force-pushed the recoDb branch 7 times, most recently from 703f43a to 7192c75 Compare November 1, 2023 08:50
chrisburr
chrisburr reviewed Nov 2, 2023
View reviewed changes
environment.yml Outdated
@@ -8,6 +8,7 @@ dependencies:
- aiohttp
- aiomysql
- aiosqlite
- asyncache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is enough code in this package to justify it as a dependency. It also doesn't seem to be that widely used or actively maintained.

@chaen chaen force-pushed the recoDb branch 3 times, most recently from cb47b37 to 31a53bf Compare November 2, 2023 13:06
@chaen chaen marked this pull request as ready for review November 2, 2023 13:12
@chaen chaen changed the title tmp handler except Reconnect DBs Nov 2, 2023
@chrisburr chrisburr merged commit d3b1652 into DIRACGrid:main Nov 2, 2023
9 checks passed
@chrisburr chrisburr mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisburr chrisburr chrisburr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application startup behaviour
2 participants
@chaen @chrisburr