Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reorder scenario color #324

Closed
wants to merge 17 commits into from

Conversation

shami-sneha
Copy link

@shami-sneha shami-sneha commented Nov 27, 2023

Description

Related Issues

Design Decisions

Performance & Quality

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

Copy link

github-actions bot commented Nov 27, 2023

Unit Test Results

  1 files  +  1  14 suites  +14   51s ⏱️ +51s
32 tests +32  32 ✔️ +32  0 💤 ±0  0 ±0 
33 runs  +33  33 ✔️ +33  0 💤 ±0  0 ±0 

Results for commit 4bd7f8c. ± Comparison against base commit b1befd5.

♻️ This comment has been updated with latest results.

@shami-sneha
Copy link
Author

Pull request for Feature/reorder scenario color

@shami-sneha shami-sneha reopened this Nov 27, 2023
@NXXR
Copy link
Collaborator

NXXR commented Nov 30, 2023

Hey @shami-sneha,

can you add a description to your PR to tell what you changed and how it works.
This PR seems to have way too many changed files 🤔
the original idea was to cheange the ordering of the colors in the Theme

@NXXR NXXR linked an issue Jan 4, 2024 that may be closed by this pull request
@NXXR
Copy link
Collaborator

NXXR commented Mar 19, 2024

already merged in #347

@NXXR NXXR closed this Mar 19, 2024
@NXXR NXXR deleted the feature/Reorder-scenarioColor branch March 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder scenario colors
2 participants