Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a editable reference date and a line connecting it to the chart. #327

Merged
merged 12 commits into from
Mar 12, 2024
Merged

Add a editable reference date and a line connecting it to the chart. #327

merged 12 commits into from
Mar 12, 2024

Conversation

JonasGilg
Copy link
Collaborator

@JonasGilg JonasGilg commented Dec 13, 2023 •
edited
Loading

Description

image

Related Issues

Resolves #319

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@JonasGilg JonasGilg requested a review from NXXR December 13, 2023 16:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Unit Test Results

  1 files  +  1  14 suites  +14   50s ⏱️ +50s
32 tests +32  32 ✔️ +32  0 💤 ±0  0 ❌ ±0 
33 runs  +33  33 ✔️ +33  0 💤 ±0  0 ❌ ±0 

Results for commit 42df9a3. ± Comparison against base commit b1befd5.

♻️ This comment has been updated with latest results.

@JonasGilg JonasGilg marked this pull request as ready for review December 13, 2023 16:24
@JonasGilg JonasGilg self-assigned this Dec 13, 2023
@JonasGilg
Merge remote-tracking branch 'origin/develop' into feature/editable-r…
1c2b0a4 
…eference-day

# Conflicts:
#	frontend/package-lock.json
#	frontend/package.json
#	frontend/src/App.tsx
#	frontend/src/components/SimulationChart.tsx
#	frontend/src/util/i18n.ts
@JonasGilg
🔧 Merge with develop.
55740eb
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

Test Results

37 tests  +3   37 ✅ +3   12s ⏱️ +3s
16 suites +1    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f5bc3b3. ± Comparison against base commit 8c0dca5.

♻️ This comment has been updated with latest results.

@JonasGilg JonasGilg merged commit ae525a5 into develop Mar 12, 2024
8 checks passed
@JonasGilg JonasGilg deleted the feature/editable-reference-day branch March 12, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NXXR NXXR NXXR approved these changes

Assignees

@JonasGilg JonasGilg

Labels
class:enhancement New feature or request type:web-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editable Reference Day
2 participants
@JonasGilg @NXXR