Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameters in backend #336

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

annawendler
Copy link
Contributor

@annawendler annawendler commented Feb 22, 2024

Description

Related Issues

Closes #335

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@annawendler annawendler linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 22, 2024

Test Results

34 tests  ±0   34 ✅ ±0   5s ⏱️ ±0s
15 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 0a34a82. ± Comparison against base commit 79c7b26.

♻️ This comment has been updated with latest results.

@annawendler annawendler requested a review from NXXR February 22, 2024 07:55
@NXXR NXXR requested review from JonasGilg and NXXR and removed request for NXXR February 22, 2024 09:16
Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine otherwise.

frontend/docs/changelog/changelog-de.md Outdated Show resolved Hide resolved
frontend/docs/changelog/changelog-en.md Outdated Show resolved Hide resolved
@annawendler annawendler requested a review from NXXR February 23, 2024 14:12
@NXXR NXXR removed the request for review from JonasGilg February 23, 2024 14:22
@annawendler annawendler merged commit 59ea85d into develop Feb 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New parameters for simulation model
2 participants