Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/parameter view #345

Merged
merged 34 commits into from
Apr 5, 2024
Merged

Feature/parameter view #345

merged 34 commits into from
Apr 5, 2024

Conversation

JonasGilg
Copy link
Collaborator

@JonasGilg JonasGilg commented Mar 15, 2024

Description

This PR changes the main content area. At the bottom the user can now choose between two tabs. One being the time series and the other is the new parameter view, which displays the infection parameters.

image
image

Related Issues

Resolves #309

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@JonasGilg JonasGilg self-assigned this Mar 15, 2024
Copy link

github-actions bot commented Mar 18, 2024

Test Results

39 tests  +2   39 ✅ +2   11s ⏱️ -1s
17 suites +1    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit bcfcc8d. ± Comparison against base commit 745f6b9.

♻️ This comment has been updated with latest results.

@JonasGilg JonasGilg marked this pull request as ready for review March 21, 2024 15:32
@JonasGilg JonasGilg requested a review from NXXR March 21, 2024 15:32
Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
just a few suggestions and open questions.

frontend/locales/de-backend.json5 Outdated Show resolved Hide resolved
frontend/locales/de-backend.json5 Outdated Show resolved Hide resolved
frontend/locales/de-backend.json5 Show resolved Hide resolved
frontend/locales/de-backend.json5 Show resolved Hide resolved
frontend/locales/en-backend.json5 Outdated Show resolved Hide resolved
frontend/src/components/MainContentTabs.tsx Outdated Show resolved Hide resolved
frontend/src/components/ParameterEditor.tsx Outdated Show resolved Hide resolved
frontend/src/components/ParameterEditor.tsx Outdated Show resolved Hide resolved
frontend/src/components/ParameterEditor.tsx Outdated Show resolved Hide resolved
frontend/src/components/ParameterEditor.tsx Outdated Show resolved Hide resolved
@JonasGilg JonasGilg requested a review from NXXR April 4, 2024 12:51
@JonasGilg JonasGilg merged commit 8058185 into develop Apr 5, 2024
8 checks passed
@JonasGilg JonasGilg deleted the feature/parameter-view branch April 5, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virus Parameter Interface
2 participants