Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database #350

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update database #350

merged 1 commit into from
Mar 26, 2024

Conversation

annawendler
Copy link
Contributor

Description

To adapt the structure of the database I made the following changes:

  • The parameters SerialInterval and IncubationTime are not used in the current model anymore, instead we now use TimeExposed and TimeInfectedNoSymptoms
  • I added another parameter ContactScaling to account for changes in the contact rate
  • I removed the group gender as discussed in todays meeting.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@annawendler annawendler requested a review from JonasGilg March 25, 2024 15:28
@annawendler annawendler merged commit bef93b1 into develop Mar 26, 2024
7 checks passed
annawendler added a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants