Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/parameter-units #356

Merged
merged 3 commits into from
May 3, 2024
Merged

feature/parameter-units #356

merged 3 commits into from
May 3, 2024

Conversation

JonasGilg
Copy link
Collaborator

@JonasGilg JonasGilg commented May 3, 2024

Description

Adds units to the parameter view and sets a new ESID release in the changelog.

Design Decisions

This hardcodes the units in the translation file. There is also logic to transform numbers with percent to be shown as percentages instead of normalized.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@JonasGilg JonasGilg requested a review from NXXR May 3, 2024 09:01
Copy link

github-actions bot commented May 3, 2024

Test Results

39 tests  ±0   39 ✅ ±0   11s ⏱️ ±0s
17 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b67e68e. ± Comparison against base commit 8058185.

♻️ This comment has been updated with latest results.

@NXXR NXXR self-assigned this May 3, 2024
Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How feasible is it to add a spanning parent cell in the header that has the category name (i.e. "Alter"/"Age")?
It could help users understand the differenty columns quicker.

@NXXR
Copy link
Collaborator

NXXR commented May 3, 2024

How feasible is it to add a spanning parent cell in the header that has the category name (i.e. "Alter"/"Age")? It could help users understand the differenty columns quicker.

decided to be moved to a separate issue

@JonasGilg JonasGilg merged commit 1d6839c into develop May 3, 2024
8 checks passed
@JonasGilg JonasGilg deleted the feature/parameter-units branch May 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants