Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range messages buffer should have a maximum size #28

Open
corot opened this issue Apr 27, 2016 · 1 comment
Open

Range messages buffer should have a maximum size #28

corot opened this issue Apr 27, 2016 · 1 comment

Comments

@corot
Copy link
Contributor

corot commented Apr 27, 2016

In my case, costmap update rate cannot cope with all the incoming readings, so buffer starts growing out of control. and so too old messages are processed after a while.

What I have done is to create a buffer per incoming topic and limit its size with a "range_msgs_buffer_size" parameter. I can PR the code, if you think it's a good idea.

Btw, I can make it a bit faster using C++11 unsorted_map instead of map. Any problem with adding C++11 requirement to range_sensor_layer?

@corot corot changed the title Buffering range messages should be optional Range messages should have a maximum size Apr 28, 2016
@corot corot changed the title Range messages should have a maximum size Range messages buffer should have a maximum size Apr 28, 2016
corot pushed a commit to corot/navigation_layers that referenced this issue May 2, 2016
@DLu
Copy link
Owner

DLu commented Jul 24, 2016

Really late to the game, but please put in a PR for the max buffer size. Thanks!

corot pushed a commit to corot/navigation_layers that referenced this issue Nov 13, 2016
DLu pushed a commit that referenced this issue Jan 7, 2021
DLu pushed a commit that referenced this issue Jan 7, 2021
DLu pushed a commit that referenced this issue Jan 7, 2021
@DLu DLu mentioned this issue Jan 7, 2021
DLu added a commit that referenced this issue Mar 2, 2021
…aximum, configurable, buffer size (#77)

Co-authored-by: Jorge Santos <[email protected]>
corot pushed a commit to corot/navigation_layers that referenced this issue May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants