judge: be more graceful around worker timeouts #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase the timeout to 60s to avoid killing the worker when a user has aborted a long-running compilation. - Rather than display `EOFError` when we kill the worker, display a more informative `TimeoutError` instead.
Xyene
force-pushed
the
worker-timeouts
branch
from
788d4bc to
2926a41
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1146 +/- ##
==========================================
- Coverage 81.30% 81.26% -0.04%
==========================================
Files 141 141
Lines 5028 5034 +6
==========================================
+ Hits 4088 4091 +3
- Misses 940 943 +3 ☔ View full report in Codecov by Sentry. |
quantum5
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOFErrorwhen we kill the worker, display a more informativeTimeoutErrorinstead.