Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare types for base checker, problems, and graders #952

Merged
merged 8 commits into from
Dec 26, 2023

Conversation

quantum5
Copy link
Member

No description provided.

@quantum5 quantum5 force-pushed the problem-types branch 2 times, most recently from 7fe8e8b to 0ebbff6 Compare September 22, 2021 09:29
@quantum5 quantum5 marked this pull request as draft September 22, 2021 22:48
@quantum5 quantum5 changed the title Declare types for base checker and problems Declare types for base checker, problems, and graders Sep 22, 2021
@quantum5 quantum5 marked this pull request as ready for review September 22, 2021 23:02
@Riolku
Copy link
Contributor

Riolku commented Mar 5, 2022

Maybe we want to bump this?

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I don't remember what the problem keeping this from being merged was anymore.

@kiritofeng kiritofeng merged commit c0b794f into master Dec 26, 2023
6 of 19 checks passed
@kiritofeng kiritofeng deleted the problem-types branch December 26, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants