Skip to content

[stable/redis-ha] fix: replace deprecated gitversion with version - #339

Closed
kvanzuijlen wants to merge 4 commits into
DandyDeveloper:masterfrom
kvanzuijlen:fix-deprecation
Closed

kvanzuijlen wants to merge 4 commits into
DandyDeveloper:masterfrom
kvanzuijlen:fix-deprecation

Conversation

@kvanzuijlen

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Capabilities.KubeVersion.GitVersion was deprecated with the release of Helm v3.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@DandyDeveloper

Copy link
Copy Markdown
Owner

@kvanzuijlen Isn't $.Capabilities.KubeVersion.Version and $.Capabilities.KubeVersion the same thing?

@kvanzuijlen

Copy link
Copy Markdown
Contributor Author

@kvanzuijlen Isn't $.Capabilities.KubeVersion.Version and $.Capabilities.KubeVersion the same thing?

I didn't know that, but indeed, after reading the docs, it is. Do you want me to change it to $.Capabilities.KubeVersion?

@DandyDeveloper

Copy link
Copy Markdown
Owner

@kvanzuijlen Yes please! If you can merge in master to fix the conflicts as well. Thank you!

@kvanzuijlen

Copy link
Copy Markdown
Contributor Author

@DandyDeveloper done!

DandyDeveloper
DandyDeveloper previously approved these changes Sep 12, 2025
@DandyDeveloper

Copy link
Copy Markdown
Owner

@kvanzuijlen Can you rebase and recommit? Hopefully the tests will pass now.

@kvanzuijlen

kvanzuijlen commented Sep 12, 2025 •

Copy link
Copy Markdown
Contributor Author

@DandyDeveloper I messed up the rebase, will close and reopen a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants