Skip to content

[charts/redis-ha] Updating README via helm-docs - #349

Merged
DandyDeveloper merged 2 commits into
masterfrom
feature/dandydev/helm-docs-readme
Sep 12, 2025
Merged

DandyDeveloper merged 2 commits into
masterfrom
feature/dandydev/helm-docs-readme

Conversation

@DandyDeveloper

Copy link
Copy Markdown
Owner

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

…ration

Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com>
Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com>
@DandyDeveloper
DandyDeveloper merged commit 2d79d92 into master Sep 12, 2025
2 checks passed
@DandyDeveloper
DandyDeveloper deleted the feature/dandydev/helm-docs-readme branch September 12, 2025 13:22
@afarbos

afarbos commented Nov 6, 2025

Copy link
Copy Markdown

@DandyDeveloper I think you should keep this part

4.34.1 - Upgrade may complain about selector label changes being immutable

This version introduced changes to the selector labels for the Deployments. Depending on the policies in your cluster, you may see an error like this when upgrading:

Error: UPGRADE FAILED: cannot patch "redis-redis-ha-haproxy" with kind Deployment: Deployment.apps "redis-redis-ha-haproxy" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"redis-ha-haproxy", "component":"haproxy", "release":"redis"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

In these cases, you'll need to delete the Deployment for the haproxy, or simple do a forceful upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants