You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Multiple enumerations of IEnumerable<SqlDataRecord> passed as TVP #2064
Looks like Dapper twice enumerates IEnumerable passed as TVP
var numbers = GenerateNumbers(3);
BulkInsert(numbers);
static IEnumerable<int> GenerateNumbers(int count)
{
for (int i = 0; i < count; i++)
{
Console.WriteLine(i);
yield return i;
}
}
void BulkInsert(IEnumerable<int> numbers)
{
var records = numbers.Select(x => MapToSqlDataRecord(x));
var sql = @"INSERT INTO [Test] (Id) SELECT Id FROM @tvp;";
using (var connection = new SqlConnection(connectionString))
{
connection.Execute(sql, new { tvp = records.AsTableValuedParameter("dbo.TestType") });
}
}
static SqlDataRecord MapToSqlDataRecord(int i)
{
var record = new SqlDataRecord(
new SqlMetaData("Id", SqlDbType.Int)
);
record.SetInt32(0, i);
return record;
}
this code writes to console
0
0
1
2
and if I pass enumerable from database it throws exception because can not open second reader on same connection (same enumerable works fine using ADO.Net)
Let's say I have any source of enumerable: db reader, http returning IAsyncEnumerable, grpc streaming, whatever
And I want to pass it to TVP without collecting the whole List in memory
I can do it using ADO.Net, but it's not possible using Dapper because of second enumeration, and it will be definitely not possible with IReadOnlyCollection
Activity
pvekshyn commentedon Apr 3, 2024
Ah, I got the idea, you are trying to avoid exception when the enumerable is empty.
This is not correct, better catch exception in this case.
mgravell commentedon Apr 3, 2024
I'm inclined to agree; at best we should type-test for
IReadOnlyCollection<T>and perform this test via.Count; anything else: just send it downpvekshyn commentedon Apr 3, 2024
Let's say I have any source of enumerable: db reader, http returning IAsyncEnumerable, grpc streaming, whatever
And I want to pass it to TVP without collecting the whole List in memory
I can do it using ADO.Net, but it's not possible using Dapper because of second enumeration, and it will be definitely not possible with IReadOnlyCollection
mgravell commentedon Apr 3, 2024
yes, I understand and agree; the point is that what we should change here is basically:
In your case, the type-test will fail, so we'll just fall into the
// main code, without doing any iteration.pvekshyn commentedon Apr 3, 2024
Great, thank you
P.S. on a second thought catching the exception is a bad idea, because sql will not be executed and caller should know about that
VinceSeely commentedon Dec 11, 2025
@mgravell I would love to try giving this problem a stab and see if I can resolve the issue.
bedamien commentedon Mar 24, 2026
Would using
Enumerable.TryGetNonEnumeratedCount()be worthwhile, over using a 'hand-rolled' check?