Test updates

DataBiosphere · Jan 6, 2025 · bb3b35f · bb3b35f
1 parent fd897b5
commit bb3b35f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/service/src/test/java/bio/terra/tanagra/service/UnderlayServiceTest.java b/service/src/test/java/bio/terra/tanagra/service/UnderlayServiceTest.java
@@ -170,11 +170,7 @@ void entityLevelHints() {
                 assertNotEquals(0, hi.getMin());
                 assertNotEquals(0, hi.getMax());
                 assertTrue(hi.getMin() >= ageRange[0]);
-
-                // TODO(BENCH-4854): computed age changes every year and max_age hint is outdated
-                // expected from hints table: 115
-                // actual computed: 116
-                // assertTrue(hi.getMax() <= ageRange[1]);
+                assertTrue(hi.getMax() <= ageRange[1]);
 
               } else if ("ethnicity".equals(attrName)) {
                 assertEquals(2, hi.getEnumValueCounts().size());

diff --git a/underlay/src/test/java/bio/terra/tanagra/datasetspecific/cmssynpuf/CmsSynpufHintsTest.java b/underlay/src/test/java/bio/terra/tanagra/datasetspecific/cmssynpuf/CmsSynpufHintsTest.java
@@ -48,7 +48,7 @@ void personEntityLevel() {
                     54_453L,
                     new ValueDisplay(Literal.forInt64(38_003_564L), "Not Hispanic or Latino"),
                     2_272_403L)),
-            new HintInstance(entity.getAttribute("age"), 40.0, 115.0),
+            new HintInstance(entity.getAttribute("age"), 40.0, 116.0),
             new HintInstance(entity.getAttribute("year_of_birth"), 1909.0, 1983.0));
     assertEntityLevelHintsMatch("person", expectedHints);
   }

diff --git a/...src/test/java/bio/terra/tanagra/query/bigquery/pagination/BQCountQueryPaginationTest.java b/...src/test/java/bio/terra/tanagra/query/bigquery/pagination/BQCountQueryPaginationTest.java
@@ -76,7 +76,6 @@ void noPagination() {
                     false));
 
     assertNotNull(countQueryResult.getSql());
-    // TODO(BENCH-4854): age is computed every time and hence highest age changes every year
     assertEquals(152, countQueryResult.getCountInstances().size());
     assertNull(countQueryResult.getPageMarker());
   }
@@ -145,7 +144,6 @@ void withPagination() {
                     false));
 
     assertNotNull(countQueryResult2.getSql());
-    // TODO(BENCH-4854): age is computed every time and hence highest age changes every year
     assertEquals(142, countQueryResult2.getCountInstances().size());
     assertNull(countQueryResult2.getPageMarker());
   }