[BENCH-4616] Update lib constraints to address vuln #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexamundsen
commented
Nov 21, 2024
| @@ -55,16 +55,6 @@ dependencies { | |||
| exclude group: 'io.opentelemetry.instrumentation' | |||
| } | |||
|
|
|||
| // explicity declare libs and version to address synk warnings | |||
| implementation "org.springframework:spring-context:${vSpringWeb}" | |||
There was a problem hiding this comment.
Not needed with spring plugin upgrade
dexamundsen
commented
Nov 21, 2024
| @@ -42,14 +42,6 @@ dependencyLocking { | |||
| dependencies { | |||
| // GCP BOM - See https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM | |||
| implementation platform('com.google.cloud:libraries-bom:26.49.0') | |||
| constraints { | |||
| // "-jre" for Java 8 or higher | |||
There was a problem hiding this comment.
no longer needed with current gcp bom
dexamundsen
commented
Nov 21, 2024
| @@ -58,13 +58,8 @@ configurations.all { | |||
| } | |||
|
|
|||
| dependencies { | |||
| // added to address synk warnings | |||
| constraints { | |||
There was a problem hiding this comment.
no longer needed
dexamundsen
commented
Nov 21, 2024
| @@ -109,16 +104,6 @@ dependencies { | |||
| implementation 'org.springframework.boot:spring-boot-starter-web' | |||
| implementation 'org.springframework.security:spring-security-core' | |||
|
|
|||
| // explicity declare libs and version to address synk warnings | |||
| implementation "org.springframework:spring-context:${vSpringWeb}" | |||
There was a problem hiding this comment.
not needed with spring plugin update
tjennison-work
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping spring plugin resolves both, and also removes the need for other constraints
indexer and underlay does not include spring plugin, hence need netty explicitly constrained