Update UI package + Cleanup overrides #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexamundsen
commented
Nov 27, 2024
| @@ -8,8 +8,11 @@ import useSWRImmutable from "swr/immutable"; | |||
| export function CohortRevision() { | |||
| const studySource = useStudySource(); | |||
| const underlaySource = useUnderlaySource(); | |||
| const { studyId, cohortId, revisionId } = | |||
| useParams<{ studyId: string; cohortId: string; revisionId: string }>(); | |||
| const { studyId, cohortId, revisionId } = useParams<{ | |||
There was a problem hiding this comment.
changes due to upgraded lint
dexamundsen
force-pushed
the
dexamundsen/ui-snyk
branch
from
0bd7344 to
547a212
Compare
dexamundsen
force-pushed
the
dexamundsen/ui-snyk
branch
from
547a212 to
801f09a
Compare
dexamundsen
commented
Dec 2, 2024
| @@ -1082,7 +1082,7 @@ function ParticipantsGroup(props: { | |||
| </GridLayout> | |||
| </GridLayout> | |||
| ) : ( | |||
| <GridLayout cols rowAlign="middle" sx={{ pl: 4 }}> | |||
| <GridLayout key={p.id} cols rowAlign="middle" sx={{ pl: 4 }}> | |||
There was a problem hiding this comment.
required in new eslint
dexamundsen
changed the title
dexamundsen
commented
Dec 2, 2024
| @@ -66,7 +66,7 @@ function OccurrenceTable({ id, config }: { id: string; config: Config }) { | |||
| root: { data: {}, children }, | |||
| }; | |||
|
|
|||
| context.rows[config.entity].forEach((o) => { | |||
| context.rows[config.entity]?.forEach((o) => { | |||
tjennison-work
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--
Underlay test is fixed in #1085