Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIE-204 Narrow Ajax Usage pt17 #5200

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

msilva-broad
Copy link
Contributor

@msilva-broad msilva-broad commented Dec 11, 2024

  • shifting ajax usage to directly use ajax sub-areas for rest of the src/workspace-data area.
  • improving mock types where possible.

also

  • test fix to remove act() warning in NewGroupModal test treated as error in pipeline.
  • minor fixed in same test file

Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]

Summary of changes:

What

Why

  • improve code maintaiability

Testing strategy

@msilva-broad msilva-broad force-pushed the msilva/UIE-204_Narrow-ajax-usage_pt17 branch from 55af1ca to b3f2612 Compare December 12, 2024 14:36
- shifting ajax usage to directly use ajax sub-areas for rest of the src/workspace-data area.
- improving mock types where possible.
- test fix to remove act() warning in NewGroupModal test treated as error in pipeline.
- minor fixed in same test file
@msilva-broad msilva-broad marked this pull request as ready for review December 12, 2024 16:31
@msilva-broad msilva-broad requested a review from a team as a code owner December 12, 2024 16:31
@msilva-broad msilva-broad added this pull request to the merge queue Dec 12, 2024
Merged via the queue into dev with commit d9f2143 Dec 12, 2024
11 checks passed
@msilva-broad msilva-broad deleted the msilva/UIE-204_Narrow-ajax-usage_pt17 branch December 12, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants