CORE-259: add User to support page #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
requested review from
a team,
dvoet,
samanehsan and
calypsomatic
and removed request for
a team and
samanehsan
dvoet
approved these changes
Jan 10, 2025
calypsomatic
approved these changes
Jan 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-259
Dependencies
Do not merge this UI change until broadinstitute/sam#1621 is live
Summary of changes:
Adds "User" as an option into the
#supportpageWhat
The User type is a bit different from the other types on this page, in that no Sam resources of type user exist; "user" is a special concept in Sam. Because of this difference, I needed to tweak the support page a bit to skip retrieving/displaying policies for the user type.
Testing strategy
Visual Aids
Screen.Recording.09-01-2025.at.16.52.mp4