As noted in #5576 (comment), we recently added walltime to the AbstractGridEngineBatchSystem prepareSubmission signature:
|
@abstractmethod |
|
def prepareSubmission( |
|
self, |
|
cpu: int, |
|
memory: int, |
|
walltime: int, |
|
jobID: int, |
|
command: str, |
|
jobName: str, |
|
job_environment: dict[str, str] | None = None, |
|
gpus: int | None = None, |
|
) -> list[str]: |
But we didn't either add it to or override the methods that call prepareSubmission in all the implementations. For example:
|
def prepareSubmission( |
|
self, |
|
cpu: int, |
|
memory: int, |
|
disk: int, |
|
jobID: int, |
|
jobName: str, |
|
command: str, |
|
environment: dict[str, str], |
|
) -> htcondor.Submit: |
We need to do that or those batch systems won't actually work.
If we got type checking working for all the batch systems, this kind of issue wouldn't happen.
┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1864
As noted in #5576 (comment), we recently added
walltimeto theAbstractGridEngineBatchSystemprepareSubmissionsignature:toil/src/toil/batchSystems/abstractGridEngineBatchSystem.py
Lines 362 to 373 in 478b287
But we didn't either add it to or override the methods that call
prepareSubmissionin all the implementations. For example:toil/src/toil/batchSystems/htcondor.py
Lines 108 to 117 in 478b287
We need to do that or those batch systems won't actually work.
If we got type checking working for all the batch systems, this kind of issue wouldn't happen.
┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1864