Skip to content

Many HPC batch systems stopped working due to walltime in prepareSubmission signature #5577

Description

@adamnovak

As noted in #5576 (comment), we recently added walltime to the AbstractGridEngineBatchSystem prepareSubmission signature:

@abstractmethod
def prepareSubmission(
self,
cpu: int,
memory: int,
walltime: int,
jobID: int,
command: str,
jobName: str,
job_environment: dict[str, str] | None = None,
gpus: int | None = None,
) -> list[str]:

But we didn't either add it to or override the methods that call prepareSubmission in all the implementations. For example:

def prepareSubmission(
self,
cpu: int,
memory: int,
disk: int,
jobID: int,
jobName: str,
command: str,
environment: dict[str, str],
) -> htcondor.Submit:

We need to do that or those batch systems won't actually work.

If we got type checking working for all the batch systems, this kind of issue wouldn't happen.

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1864

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions