RUMM-1625 Do not run nightly tests below iOS 11.0.0 #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and devices) when tool fails.
This is to prevent CI failures, when too old simulators can be installed on the host (CI machine).
buranmert
approved these changes
Sep 24, 2021
ncreated
deleted the
ncreated/RUMM-1625-do-not-run-nightly-tests-below-supported-OS-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🐞 This PR fixes an issue in nightly tests automation, where sometimes it was trying to run unit tests on
iOS 10.x.How?
Our nightly tests automation looks at all installed and available for installation Simulators in host environment (CI machine). Then it picks few Simulators (randomly) and runs tests (if Simulator is pre-installed) or installs the Simulator and then runs tests. Because
iOS 10.xsimulator can be installed on macOS Catalina, it was sometimes picked by our automation.I added
MIN_SUPPORTED_IOS_VERSIONvariable to filter out unsupported versions from test plan.Also, I added
dump_environment()function to print more information about the Simulators, Runtimes and Devices when automation fails. This should be handy for debugging issues like iOS 15.0 Simulator not being visible byxcode-install.Review checklist