Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove assert in box #23

Merged
merged 2 commits into from
Sep 24, 2024
Merged

remove assert in box #23

merged 2 commits into from
Sep 24, 2024

Conversation

hschreiber
Copy link
Contributor

No description provided.

@hschreiber hschreiber marked this pull request as ready for review September 24, 2024 13:22
DavidLapous
DavidLapous reviewed Sep 24, 2024
View reviewed changes
Copy link
Owner

@DavidLapous DavidLapous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could still keep the size check (up to a is_finite)

DavidLapous
DavidLapous approved these changes Sep 24, 2024
View reviewed changes
Copy link
Owner

@DavidLapous DavidLapous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidLapous DavidLapous merged commit ba175c1 into DavidLapous:main Sep 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidLapous DavidLapous DavidLapous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hschreiber @DavidLapous