Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException when checking for existence of projects without version - port upstream fix #365

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

VithikaS
Copy link
Collaborator

@VithikaS VithikaS commented Oct 19, 2023

Description

Port NPE fix when project does not have version

Addressed Issue

Ports DependencyTrack/dependency-track#2966 and DependencyTrack/dependency-track#3068

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: vithikashukla <[email protected]>
@VithikaS VithikaS changed the title Port pr-3068 changes Port pr-3068 - Fix NullPointerException when checking for existence of projects without version Oct 19, 2023
@VithikaS VithikaS added the defect Something isn't working label Oct 19, 2023
@nscuro
Copy link
Member

nscuro commented Oct 19, 2023

The original PR fixed a regression introduced in an earlier "fix": DependencyTrack/dependency-track#2966

The doesProjectExist method was added there: https://github.com/DependencyTrack/dependency-track/pull/2966/files#diff-75cd29a0a085d84dff3cb4794242e0d1b400385f1acfae172346c3e6780629b0R1143-R1165

But damn, great you found another problematic area! :D

@VithikaS
Copy link
Collaborator Author

The original PR fixed a regression introduced in an earlier "fix": DependencyTrack/dependency-track#2966

The doesProjectExist method was added there: https://github.com/DependencyTrack/dependency-track/pull/2966/files#diff-75cd29a0a085d84dff3cb4794242e0d1b400385f1acfae172346c3e6780629b0R1143-R1165

But damn, great you found another problematic area! :D

Oh no.. what did i do.. damn.. i will add the original "fix"

vithikashukla and others added 2 commits October 19, 2023 17:30
Co-authored-by: nscuro <[email protected]>
Signed-off-by: vithikashukla <[email protected]>
Co-authored-by: nscuro <[email protected]>
Signed-off-by: vithikashukla <[email protected]>
@VithikaS
Copy link
Collaborator Author

The original PR fixed a regression introduced in an earlier "fix": DependencyTrack/dependency-track#2966
The doesProjectExist method was added there: https://github.com/DependencyTrack/dependency-track/pull/2966/files#diff-75cd29a0a085d84dff3cb4794242e0d1b400385f1acfae172346c3e6780629b0R1143-R1165
But damn, great you found another problematic area! :D

Oh no.. what did i do.. damn.. i will add the original "fix"

Added original fix with null version check. Ready for review now

@VithikaS VithikaS changed the title Port pr-3068 - Fix NullPointerException when checking for existence of projects without version Fix NullPointerException when checking for existence of projects without version - port upstream fix Oct 19, 2023
@nscuro nscuro merged commit 492bd76 into main Oct 20, 2023
6 checks passed
@nscuro nscuro deleted the port-pr-3068-in-DT branch October 20, 2023 07:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants