Add `vers` range validation before compilation #455

sahibamittal · 2023-11-23T16:20:46Z

It would be good if we could perform the validation during the CEL script compilation, in order to give users feedback synchronously.

I have read and understand the contributing guidelines
This PR fixes a defect, and I have provided tests to verify that the fix is effective
This PR implements an enhancement, and I have provided tests to verify that it works as intended
This PR introduces changes to the database model, and I have added corresponding update logic
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

src/main/java/org/dependencytrack/policy/cel/CelPolicyScriptHost.java

sahibamittal added 2 commits November 23, 2023 16:19

add ver range check before compilation

448caf2

Update CelPolicyScriptVisitor.java

54c4303

sahibamittal requested a review from nscuro November 24, 2023 11:18

nscuro reviewed Nov 24, 2023

View reviewed changes

src/main/java/org/dependencytrack/policy/cel/CelPolicyScriptHost.java Show resolved Hide resolved

added check for step expressions

5a05a18

sahibamittal requested a review from nscuro November 27, 2023 14:49

update vers range check

4d474f8

nscuro approved these changes Nov 27, 2023

View reviewed changes

nscuro added the enhancement New feature or request label Nov 27, 2023

nscuro changed the title ~~Add vers range check before compilation~~ Add vers range validation before compilation Nov 27, 2023

nscuro merged commit c309d0a into main Nov 27, 2023
6 checks passed

nscuro deleted the validate-vers-range-cel-compile branch November 27, 2023 16:38

github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023

nscuro added this to the 5.3.0 milestone Feb 7, 2024

Provide feedback