Fix: add support output for ARs #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-senichenkov
force-pushed
the
AR-support-output
branch
2 times, most recently
from
b2ccc1e to
2b49d23
Compare
chernishev
force-pushed
the
AR-support-output
branch
from
2b49d23 to
ee0dac0
Compare
Sched71
suggested changes
Nov 27, 2024
| @@ -318,4 +338,28 @@ TEST_F(ARAlgorithmTest, RepeatedExecutionConsistentResult) { | |||
| } | |||
| } | |||
|
|
|||
| TEST_F(ARAlgorithmTest, SupportAndConfidenceSingular) { | |||
| auto algorithm = CreateAlgorithmInstance(kRulesBook, 0.2, 0.5, 0, 1); | |||
There was a problem hiding this comment.
I guess last parameter should be true
There was a problem hiding this comment.
No, it shouldn't. The last parameter is itemColumnIndex, which is unsigned int.
Add output of the support value for Association Rules
Illustrate that "support" now can be calculated
Replace ASSERT with EXPECT and FAIL with ADD_FAILURE in CheckSupportAndConfidence
p-senichenkov
force-pushed
the
AR-support-output
branch
from
ee0dac0 to
7981cad
Compare
chernishev
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add output of the support value for Association Rules