Skip to content

chore: remove unused dependencies in apps - #36103

Merged
GoodDayForSurf merged 17 commits into
DevExpress:mainfrom
GoodDayForSurf:main_remove_apps_unused_deps
Nov 5, 2026
Merged

GoodDayForSurf merged 17 commits into
DevExpress:mainfrom
GoodDayForSurf:main_remove_apps_unused_deps

Conversation

@GoodDayForSurf

Copy link
Copy Markdown
Contributor

No description provided.

@GoodDayForSurf GoodDayForSurf self-assigned this Nov 3, 2026
@GoodDayForSurf
GoodDayForSurf marked this pull request as ready for review November 4, 2026 19:05
@GoodDayForSurf
GoodDayForSurf requested review from a team and a balanced review from Copilot November 4, 2026 19:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The lockfile removes native bindings required by Rolldown 1.2.14, causing Vite to fail when loaded after a clean frozen install.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

This PR trims dependencies from DevExtreme’s demo and playground apps and updates the shared pnpm lockfile.

Changes:

  • Removes selected runtime and development dependencies from four app manifests.
  • Updates lockfile dependency links and removes associated package records.
File Description
pnpm-lock.yaml Updates app dependency entries and prunes package snapshots.
apps/​vue/​package.json Removes compiler, testing, matching, and routing dependencies.
apps/​react-storybook/​package.json Removes prop-types.
apps/​demos/​package.json Removes selected framework, localization, linting, and utility dependencies.
apps/​angular/​package.json Removes @angular/router and ts-node.

Review effort: Balanced

Comment thread pnpm-lock.yaml Resolved
Copilot AI balanced review requested due to automatic review settings November 5, 2026 08:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the dependency cleanup and associated lockfile updates.

No open issues 🎉

1 resolved since last review
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the dependency cleanup and corresponding lockfile updates.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the app dependency cleanup and shared lockfile update.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

vorobey
vorobey previously approved these changes Nov 5, 2026
…main_remove_apps_unused_deps

# Conflicts:
#	pnpm-lock.yaml
Copilot AI balanced review requested due to automatic review settings November 5, 2026 16:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the dependency cleanup and corresponding lockfile updates.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the dependency cleanup.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

@GoodDayForSurf
GoodDayForSurf added this pull request to the merge queue Nov 5, 2026
Merged via the queue into DevExpress:main with commit 5ec7c35 Nov 5, 2026
466 of 488 checks passed
@GoodDayForSurf
GoodDayForSurf deleted the main_remove_apps_unused_deps branch November 5, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants