You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Keyboard submission while a request is pending can erase user input, and tool calls at the round limit can silently produce an empty answer reported as successful across the demo implementations.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Retry submissions are silently skipped while the error alert remains visible, and the CSP image allowlist excludes the demo’s data-URL assistant avatar.
After a request fails, Chat is re-enabled while the alert remains for 60 seconds; submissions during that interval appear in the conversation but never reach the model because this guard skips processing. Process submissions independently of alert visibility, and remove Angular's matching alert guard around toggleDisabledState so retries still disable Chat. The same issue occurs in this demo's ReactJs/App.js:57, Vue/App.vue:260, jQuery/index.js:280, and Angular/app/app.service.ts:374 (with the matching component guard at Angular/app/app.component.ts:87).
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
After an API or round-limit error, alert-dependent guards silently block subsequent submissions for 60 seconds despite re-enabling the composer, preventing retries across multiple demo implementations.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Error alert blocks chat retries after the composer is re-enabled
After an API or round-limit error, Chat is re-enabled while the alert remains for 60 seconds; subsequent submissions are displayed, but this guard prevents them from reaching the model or conversation history. Allow retries independently of alert visibility in both submission handlers, or keep the composer disabled during an explicit cooldown. The same issue occurs in this demo's ReactJs/App.js:57, Vue/App.vue:260, jQuery/index.js:280, and Angular/app/app.service.ts:374; allowing Angular retries also requires removing the alert-dependent busy-state guard in Angular/app/app.component.ts:87.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because post-failure alert handling can show new submissions in the transcript without sending them to the model or recording them in its history across multiple demo implementations.
No open issues 🎉
Review effort: Balanced
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬