Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MX beamlines to use new device factory - Part 1 #735

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jan 7, 2025

This addresses

See also dodal PR

Additionally, this PR also adds unit test duration summary to the end of pytest, this was done because it seems that tests are taking longer, see related issue that is not addressed here

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (967bc4e) to head (a16bb7f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         101      101           
  Lines        6931     6933    +2     
=======================================
+ Hits         6028     6030    +2     
  Misses        903      903           
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.53% <100.00%> (+<0.01%) ⬆️
other 96.58% <ø> (ø)

@rtuck99
Copy link
Contributor Author

rtuck99 commented Jan 8, 2025

Need to update beamline for

@olliesilvester olliesilvester changed the title Dodal 846 update mx beamlines to use device factory Update MX beamlines to use new device factory Jan 8, 2025
@rtuck99 rtuck99 changed the title Update MX beamlines to use new device factory Update MX beamlines to use new device factory - Part 1 Jan 9, 2025
@rtuck99 rtuck99 force-pushed the dodal_846_update_mx_beamlines_to_use_device_factory branch from 5dfe500 to b1b8a49 Compare January 10, 2025 16:03
@rtuck99 rtuck99 force-pushed the dodal_846_update_mx_beamlines_to_use_device_factory branch from b1b8a49 to a16bb7f Compare January 13, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant