-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MX beamlines to use new device factory - Part 1 #735
Open
rtuck99
wants to merge
10
commits into
main
Choose a base branch
from
dodal_846_update_mx_beamlines_to_use_device_factory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update MX beamlines to use new device factory - Part 1 #735
rtuck99
wants to merge
10
commits into
main
from
dodal_846_update_mx_beamlines_to_use_device_factory
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 101 101
Lines 6931 6933 +2
=======================================
+ Hits 6028 6030 +2
Misses 903 903
|
Need to update beamline for |
olliesilvester
changed the title
Dodal 846 update mx beamlines to use device factory
Update MX beamlines to use new device factory
Jan 8, 2025
rtuck99
changed the title
Update MX beamlines to use new device factory
Update MX beamlines to use new device factory - Part 1
Jan 9, 2025
rtuck99
force-pushed
the
dodal_846_update_mx_beamlines_to_use_device_factory
branch
from
January 10, 2025 16:03
5dfe500
to
b1b8a49
Compare
rtuck99
force-pushed
the
dodal_846_update_mx_beamlines_to_use_device_factory
branch
from
January 13, 2025 13:46
b1b8a49
to
a16bb7f
Compare
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses
See also dodal PR
Additionally, this PR also adds unit test duration summary to the end of pytest, this was done because it seems that tests are taking longer, see related issue that is not addressed here
setup_context()
unexpected behaviour dodal#973