Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix Taproot activation and wallet_taproot.py functional test #258

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

gto90
Copy link
Member

@gto90 gto90 commented Dec 19, 2024

This pull request includes several updates to the Taproot soft fork tests and the blockchain info RPC. The changes involve updating constants, adjusting test parameters, and modifying the blockchain info output.

Updates to Taproot softfork tests:

Modifications to blockchain info RPC:

  • test/functional/rpc_blockchain.py: Changed the Taproot status to 'active', updated the start time and timeout values, and added the height field in the blockchain info output.

Motivation

These changes ensure compatibility and accuracy for the updated Taproot soft fork parameters and protocol behaviors. Specifically, the modifications address issues in the wallet_taproot.py functional test, which validates the generation and spending of Pay-to-Taproot (P2TR) addresses.

Testing

•	Ran the wallet_taproot.py functional test suite and confirmed all tests pass successfully.
•	Verified correct handling of Taproot-related descriptors in both activated and non-activated scenarios.

Additional Notes

No changes to the documentation or other test suites are required as part of this update.

This commit fixes the feature_taproot.py functional test by correctly setting DUST_LIMIT and MIN_FEE to match 8.22 fee changes and COINBASE_MATURITY_2.
This commit fixes the feature_taproot.py functional test by correctly setting DUST_LIMIT and MIN_FEE to match 8.22 fee changes and COINBASE_MATURITY_2.
@gto90 gto90 added the bug Something isn't working label Dec 19, 2024
@gto90 gto90 self-assigned this Dec 19, 2024
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Great work @gto90! Client compiles, runs and test passes with:

python3 test/functional/test_runner.py feature_taproot.py

Screenshot 2024-12-19 at 9 22 34 AM

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Amazing work @gto90!

@ycagel ycagel merged commit 47ba50a into develop Dec 19, 2024
2 checks passed
@gto90 gto90 deleted the bugfix/test-feature_taproot branch December 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants