Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 #230

Draft
wants to merge 75 commits into
base: master
Choose a base branch
from
Draft

v4 #230

wants to merge 75 commits into from

Conversation

DoctorMcKay
Copy link
Owner

@DoctorMcKay DoctorMcKay commented Sep 24, 2019

Breaking Changes

  • Now requires Node.js v14 or later
  • Removed deprecated getInventoryHistory method
  • Removed deprecated confirmation checker
  • Removed deprecated getWebApiOauthToken method
  • Removed chat support (all chat, including webchat goes through CMs now)
  • SteamCommunity.ConfirmationType is now accessible as SteamCommunity.EConfirmationType
  • Removed deprecated behavior in SteamCommunity constructor where the first argument could be localAddress rather than an options object
  • Removed request dependency
    • httpRequest has new behavior now
    • Pre- and post- HTTP request hooks have new behavior now
    • httpRequestGet and httpRequestPost have been removed
  • Changes to TOTP tags used for confirmations
    • getConfirmations now uses 'list' instead of 'conf'
    • getConfirmationOfferID now uses 'detail' instead of 'details'
    • respondToConfirmation and CConfirmation#respond now use 'reject' and 'accept' instead of 'cancel' and 'allow'
    • acceptAllConfirmations now uses list and accept
  • login now uses steam-session internally, and only returns a promise (no callback support)

TODO

  • Code cleanup
  • Promise support for everything
  • Make sure examples are up to date
  • Switch from request to axios or got
  • Figure out why promise rejection stack traces are sometimes useless

@Revadike
Copy link
Contributor

How about: TODO - merge or close open pull requests

@ghost
Copy link

ghost commented May 4, 2021

C'mon dude, you can do this! Don't give up

@Revadike
Copy link
Contributor

Revadike commented May 19, 2021

Other TODO suggestions:

  • Merge or close open pull requests
  • Replace deprecated request module (I recommend got)
  • Use ESLint for formatting (My ESLint config)
  • Use ES6 syntax and features (you're already adding this, but was not yet on the list)

I could perhaps help out, but only if it's going to be accepted. I hate having my PR's rejected.

@DoctorMcKay DoctorMcKay marked this pull request as draft July 22, 2021 07:05
@DoctorMcKay DoctorMcKay linked an issue Jul 22, 2021 that may be closed by this pull request
@DoctorMcKay DoctorMcKay added this to the v4 milestone Jul 22, 2021
# Conflicts:
#	components/confirmations.js
#	components/groups.js
#	components/market.js
#	package.json
@Revadike
Copy link
Contributor

I highly suggest setting up ESLint, so you don't have to format each file manually. ESLint can format on-save and fix formatting rules.

@DoctorMcKay DoctorMcKay changed the title [WIP] v4 v4 Jul 22, 2021
# Conflicts:
#	components/http.js
#	components/users.js
#	package.json
@Revadike
Copy link
Contributor

Other TODO suggestions:

  • Replace deprecated request module (I recommend got)

While got is a nice library, I never use it anymore. I simply use node-fetch, which is eventually going to be native module to node. It's just easier to use the same syntax everywhere. You can copy as fetch in browser dev tools. And if you're worried about cookie support, I just use fetch-cookie or you can use one of the many other similar libraries. You can support proxies by passing an agent in the request options.

@DoctorMcKay
Copy link
Owner Author

DoctorMcKay commented Apr 25, 2023

https://github.com/DoctorMcKay/node-stdlib/blob/master/src/lib/http/client/HttpClient.ts

I just made this today because I'm tired of not having full control over the HTTP stack. I don't want to get invested in some library and then find out that I can't do something like streamed uploads or whatever.

@Revadike
Copy link
Contributor

Revadike commented Jan 3, 2025

6 years in the making. time flies :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace request package
6 participants