-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 #230
base: master
Are you sure you want to change the base?
v4 #230
Conversation
# Conflicts: # index.js # package.json
How about: TODO - merge or close open pull requests |
C'mon dude, you can do this! Don't give up |
Other TODO suggestions:
I could perhaps help out, but only if it's going to be accepted. I hate having my PR's rejected. |
# Conflicts: # components/confirmations.js # components/groups.js # components/market.js # package.json
I highly suggest setting up ESLint, so you don't have to format each file manually. ESLint can format on-save and fix formatting rules. |
# Conflicts: # components/http.js # components/users.js # package.json
While |
https://github.com/DoctorMcKay/node-stdlib/blob/master/src/lib/http/client/HttpClient.ts I just made this today because I'm tired of not having full control over the HTTP stack. I don't want to get invested in some library and then find out that I can't do something like streamed uploads or whatever. |
# Conflicts: # components/confirmations.js # components/inventoryhistory.js # components/twofactor.js # components/users.js # components/webapi.js # index.js # package.json
6 years in the making. time flies :P |
Breaking Changes
getInventoryHistory
methodgetWebApiOauthToken
methodSteamCommunity.ConfirmationType
is now accessible asSteamCommunity.EConfirmationType
SteamCommunity
constructor where the first argument could belocalAddress
rather than anoptions
objectrequest
dependencyhttpRequest
has new behavior nowhttpRequestGet
andhttpRequestPost
have been removedgetConfirmations
now uses 'list' instead of 'conf'getConfirmationOfferID
now uses 'detail' instead of 'details'respondToConfirmation
andCConfirmation#respond
now use 'reject' and 'accept' instead of 'cancel' and 'allow'acceptAllConfirmations
now useslist
andaccept
login
now uses steam-session internally, and only returns a promise (no callback support)TODO
Code cleanupSwitch from request to axios or got