Unity Package Manager Support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file 'ResourceUtility.cs' contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS). It is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.
This was necessary to avoid loading package assets using "Assets" absolute path. Using Resources API in Editor is much simpler and has no optimization drawbacks since assets in Editor/Resources are not included in build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to Splines Issue
Comments
I replaced
ResourceUtilitycalls with Resources API. This was necessary to avoid loading package assets using "Assets" absolute path. Using Resources API in Editor is much simpler and has no optimization drawbacks since assets in Editor/Resources are not included in buildI also had to reformat
ResourceUtilitybefore editing it. I advise reviewing the PR commit by commitSee also: Splines PR