WIP: WG fallbacks for missing Size/Posn and missing per-component WG code #345
+429
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a generic WG handler when no custom one is found - simply queries what data we have in refData. Universal Size and Posn checks if they were requested and not set in the response to be returned. If not found, will query the DOM to find the size and position.
Add a generic WG handler when no custom one is found - simply queries what data we have in refData. Universal Size and Posn checks if they were requested and not set in the response to be returned. If not found, will query the DOM to find the size and position.
The many if statements formed a quasi switch statement, and as there was no default, it worked fine. I know need a default and it's easier to avoid mistakes if we use else if statements. Don't crash on invalid IDs for size and pos, return [0, 0] as sentinel values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts two issues:
Fallback # 1: At least partially, issues such as #303 . There may be more to #303 , but this essentially allows every component to support a default implementation of Size and Posn. This is found by querying the bounding box on the rendered HTML. If you request Size and Posn on something that is not rendered, you get {'Size': [0, 0], 'Posn': [0, 0]}. This won't happen if there's custom code providing a Size and Posn already.
Fallback # 2: WG calls with no implementation would silently fail, even though the WC succeeded and the data exists in the client-side representation of the tree. A default implementation simply now tries to fetch the requested data directly from the tree, returning whatever it can find.