Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possiblity to restrict the json query when creating the VOMS files #26

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

Pansanel
Copy link
Contributor

@Pansanel Pansanel commented Jun 13, 2023

Summary

When using this module on a site, it takes a long time to go through all the VOs. This pull request permits to restrict the VOMS file generation to the VOs supported by the site. For doing this, the site admin should only set the supported_vos variable. ie.:

supported_vo:
  - biomed
  - dteam
  - ops

If the supported_vos is not set, then all the VOMS files are created (the default behaviour of this module is not modified).

Fix #25

@Pansanel Pansanel requested a review from a team as a code owner June 13, 2023 07:15
@gwarf
Copy link
Member

gwarf commented Jun 13, 2023

Thanks a lot @Pansanel, it's something that was really missing and that will help a lot!
We will look in testing this ASAP, but with the EGI Conference coming, it may take some time.

@gwarf gwarf self-assigned this Jun 13, 2023
@Pansanel
Copy link
Contributor Author

Hi,
Any news @gwarf ?

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to have tests though

@enolfc
Copy link
Contributor

enolfc commented Mar 1, 2024

@Pansanel do you need this to be merged soon? I can do it, but would prefer to have @gwarf approving as well

@Pansanel
Copy link
Contributor Author

Pansanel commented Mar 1, 2024

@enolfc : there is no urgency. It's mainly so that this PR is being reviewed.

@gwarf
Copy link
Member

gwarf commented Jan 17, 2025

I was willing to test this furthermore, but I lacked time, and it seems that the molecule stuff would need some refresher to work properly with the last version of molecule.
Let's merge, I will also try to test this in the context of using an AlmaLinux 9 with UDM 5 repositories.
Sorry for the delay @Pansanel :/

@gwarf gwarf merged commit 60eb8b3 into EGI-Federation:main Jan 17, 2025
2 checks passed
@gwarf
Copy link
Member

gwarf commented Jan 17, 2025

From my quick tests it works great and saves a lot of time, thanks a lot @Pansanel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to configure only specific VO
3 participants