Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bdii-slapd-start startup script #48

Closed
wants to merge 1 commit into from
Closed

Update bdii-slapd-start startup script #48

wants to merge 1 commit into from

Conversation

VilleS1
Copy link

@VilleS1 VilleS1 commented Nov 8, 2023

If both ipv6 and ipv4 addresses are being used the systemd script breaks because of quotes in the options. This is the fix.

Summary


Related issue :

If both ipv6 and ipv4 addresses are being used the systemd script breaks because of quotes in the options. This is the fix.
@VilleS1 VilleS1 requested a review from a team as a code owner November 8, 2023 08:35
@VilleS1
Copy link
Author

VilleS1 commented Nov 9, 2023

Looks like your " Install AlmaLinux 8 RPMs (pull_request) " test is broken. It tries to find packages in wrong url.

@gwarf
Copy link
Member

gwarf commented Nov 9, 2023

Thanks for the PR!
Yep the tests are to be updated, we will look at this.
We need to put in place such an IPv4/IPv6 BDII instance to test your change, and see if we can do something a bit cleaner, personally I'm not fond of the array with bash -c call and the later command execution.

@VilleS1
Copy link
Author

VilleS1 commented Nov 9, 2023

Shell is needed I guess for env (service won't start otherwise) and bash needs an array to not break the quotes so I am interested to see what you come up with. This is on Ubuntu 20.04.06 LTS. Everything needs to work under systemd which is a different thing than running the scripts directly.

@brucellino
Copy link
Member

WIP #50

@brucellino
Copy link
Member

Hey @VilleS1. We have decided to merge #51 instead.
I'm closing this -- Thank you very much anyway for the contribution and effort.

@brucellino brucellino closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bdii-slapd-start breaks when BDII_IPV6_SUPPORT=yes
3 participants