-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organise contributor page for development environment #637
Comments
Today I just came across https://github.com/flox/flox which may also help us keep a consistent environment throughout. |
This actually looks like a really good idea. I was going to suggest using asdf instead, but I was convinced by this comment in the Elixr forum. Coming from the Nix world, and assuming the project will be stable long term, it looks like a good approach. |
# Summary The "version" of docsy that we use is generating the issue described in #639 with the latest versions of `hugo`. According to my tests the latest working version of `hugo` is [v0.110.0](https://github.com/gohugoio/hugo/releases/tag/v0.110.0). In addition to specifying the latest working version of `hugo` in the docs to contribute, I am also adding an [environment with flox](https://flox.dev/docs/tutorials/sharing-environments/#sharing-environments-with-files). See also related discussion in #637. Merging this PR fixes #639. However, we may also want to discuss whether to [migrate docsy from git submodules to hugo modules](https://www.docsy.dev/docs/updating/convert-site-to-module/) so the latest version of both `hugo` and `docsy` can be used. --- **Related issue :** #639
As #668 got merged, can/should this issue be closed? |
Please note that in the flox environment in #668 we only pinned the version of |
For the record, the version somewhat pinned in the GitHub actions is pretty vague: https://github.com/EGI-Federation/documentation/blob/main/.github/workflows/build.yml#L32-L35 |
Re-organise development environment page
In order to contribute anything, you likely need the dev env working. I hold that this should be on a single page.
In the page https://docs.egi.eu/about/contributing/git/#installing-dependencies there is mention of installing NodeJS as a dependency. I propose suggesting the use of NVM.sh for contributors to manage various Node versions:
NVM.sh
is just a shell script which can be added using thecurl - | bash
method, and provides functionality similar to python's virtual environments.Further, it's stated that NodeJS 12 should be used in the environment, but this is not declared anywhere. We should add it to
package.json
Finally, if we merge #636 we will obviate the need for many of the local tests reproducing the checks run in the actions CI checks, since they will be taken care of by the pre-commit framework. For now, I propose keeping the existing documentation, but instructing contributors to install the pre-commit hooks when contributing.
Summary of proposed changes
I propose:
The text was updated successfully, but these errors were encountered: